-
Notifications
You must be signed in to change notification settings - Fork 332
Dotty 0.3.0-RC2 announcement #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@heathermiller Can you please review? |
|
LGTM! @allanrenucci do you want to merge now, or wait till tomorrow? |
|
The release has not landed into maven yet. We will wait until tomorrow. |
|
Sounds good. If that's the case, then please update the date on this article by renaming the file 😉 |
|
Minor suggestions:
|
8aee32c to
bc8b1de
Compare
|
@smarter I have added a |
|
@heathermiller Can you merge it? Thanks! |
|
Done 🙂 |
|
There seems to be an issue with the rendering of the website |
| @@ -0,0 +1,150 @@ | |||
| --- | |||
| layout: blog | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout should be blog-detail, not blog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
|
In general @allanrenucci, you need to follow the instructions in the README to build and test the blog article locally. It isn't enough to just make a PR with some markdown in it to scala-lang. |
|
Thanks @ashawley for debugging it so quickly! |
|
Fixed in 165564a |
|
@heathermiller Not sure whom to ask for this, but could the blog post be tweeted by https://twitter.com/scala_lang ? |
|
Sure, I'll do it now. |
No description provided.