Skip to content

Conversation

@allanrenucci
Copy link
Contributor

No description provided.

@allanrenucci
Copy link
Contributor Author

@heathermiller Can you please review?

@heathermiller
Copy link
Member

LGTM! @allanrenucci do you want to merge now, or wait till tomorrow?

@allanrenucci
Copy link
Contributor Author

The release has not landed into maven yet. We will wait until tomorrow.

@heathermiller
Copy link
Member

Sounds good. If that's the case, then please update the date on this article by renaming the file 😉

@smarter
Copy link
Member

smarter commented Sep 6, 2017

Minor suggestions:

@allanrenucci
Copy link
Contributor Author

@smarter I have added a Reporting Bugs and Contributing sections

@allanrenucci
Copy link
Contributor Author

@heathermiller Can you merge it? Thanks!

@heathermiller heathermiller merged commit e15ffd4 into scala:master Sep 7, 2017
@heathermiller
Copy link
Member

Done 🙂
Should be live in a minute or two!

@allanrenucci
Copy link
Contributor Author

There seems to be an issue with the rendering of the website

@@ -0,0 +1,150 @@
---
layout: blog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout should be blog-detail, not blog.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@heathermiller
Copy link
Member

In general @allanrenucci, you need to follow the instructions in the README to build and test the blog article locally. It isn't enough to just make a PR with some markdown in it to scala-lang.

@heathermiller
Copy link
Member

Thanks @ashawley for debugging it so quickly!

@heathermiller
Copy link
Member

Fixed in 165564a

@smarter
Copy link
Member

smarter commented Sep 8, 2017

@heathermiller Not sure whom to ask for this, but could the blog post be tweeted by https://twitter.com/scala_lang ?

@heathermiller
Copy link
Member

Sure, I'll do it now.

@heathermiller
Copy link
Member

Done: https://twitter.com/scala_lang/status/906290538214813702

@allanrenucci allanrenucci deleted the blog_post branch October 16, 2017 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants